Denis Roussel (ACSONE)

Results 1469 comments of Denis Roussel (ACSONE)

@Mantux11 Can you review this in order to integrate it here too ? https://github.com/OCA/account-analytic/pull/423 Thanks

> @rousseldenis I'm integrated. Migration script's I guess isn't needed because you do that in `14.0` version, so I don't add that. If it's needed, say, I would insert here...

@airlessproject FYI, I've done something more clever there : https://github.com/OCA/account-analytic/pull/413/commits/12bd16ce32eecdd5d0ddc8a1f51002e03904b1b7 You can select the default behaviour as an option.

> > @airlessproject FYI, I've done something more clever there : [12bd16c](https://github.com/OCA/account-analytic/commit/12bd16ce32eecdd5d0ddc8a1f51002e03904b1b7) > > You can select the default behaviour as an option. > > @rousseldenis it looks good, thanks...

> > > > @airlessproject FYI, I've done something more clever there : [12bd16c](https://github.com/OCA/account-analytic/commit/12bd16ce32eecdd5d0ddc8a1f51002e03904b1b7) > > > > You can select the default behaviour as an option. > > >...

> Hi @rousseldenis what is the status of this PR? is the module still needed? This is currently in production for months and ready for review.

@AaronHForgeFlow I've updated this by reactivating tests, and introducing a grouping strategy option. Per line or per order. @cubells @pedrobaeza @carlosdauden Review is welcome.

> Uhm, a weird commit separation. Isn't this overlapping with the module `procurement_purchase_no_grouping`? Mmmh, yes and no. This is oriented on analytic account only.

> OK, for me, 2 PO lines with different analytic account should never get merged, but if you think so. Neither do I. In standard, analytic account is not managed,...

> Hi all, just a heads up to something we discovered with @rousseldenis in another PR, that most of the functionality in `purchase_procurement_analytic` is already in `procurement_mto_analytic`, and the latter...