[15.0][MIG] stock_analytic: migration

[Mantux11]

Migration to 15.0. product file was deleted, because in original odoo 14 code _anglo_saxon_sale_move_lines function was deleted. I don't know why this was left in 14.0 migration, but I say that, if no one had problems, I don't see any issues that is associated with this, so I assume that this is not necessary to leave a file that don't do anything. Improved tests.

[rousseldenis]

@Mantux11 Can you review this in order to integrate it here too ?

https://github.com/OCA/account-analytic/pull/423

Thanks

[Mantux11]

@rousseldenis I'm integrated. Migration script's I guess isn't needed because you do that in 14.0 version, so I don't add that. If it's needed, say, I would insert here also.

[rousseldenis]

@rousseldenis I'm integrated. Migration script's I guess isn't needed because you do that in 14.0 version, so I don't add that. If it's needed, say, I would insert here also.

Oops.

The good way is to cherry-pick it in order to keep authorship. Can you do it ?

And indeed, in your migration commit you can remove migration scripts.

[Mantux11]

@rousseldenis I'll wait for your PR merge, because it would be easier for me to cherry pick.

[Olageibol]

In order to maintain the data security, I believe that the analytic_account_id field in stock.move.line views needs the analytic group added to it. https://github.com/vialaurea/OCA-account-analytic/blob/15.0-mig-stock_analytic/stock_analytic/views/stock_move_line.xml

[AaronHForgeFlow]

can you include this? https://github.com/OCA/account-analytic/pull/423

[Mantux11]

@AaronHForgeFlow yes, I would do that ASAP.

[jlzhou]

@Mantux11 thanks for your effort!

Could you please explain why remove _prepare_procurement_values override from stock.move model?

def _prepare_procurement_values(self): """ Allows to transmit analytic account from moves to new moves through procurement. """ res = super()._prepare_procurement_values() if self.analytic_account_id: res.update( { "analytic_account_id": self.analytic_account_id.id, } ) return res

[oca-clabot]

Hey @Mantux11, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:

• BT-cserra [email protected] (no github login found)
• Hanane ELKHAL [email protected] (no github login found)
• Hanane [email protected] (no github login found)
• Cas Vissers [email protected] (no github login found)

Appreciation of efforts, OCA CLAbot

[Mantux11]

@AaronHForgeFlow I added all comitt's from 14. @jlzhou Returned this function,

[Mantux11]

@AaronHForgeFlow @jlzhou Could you Merge this PR? It's a valid migration, and it hasn't been reviewed for more than a month.

[AaronHForgeFlow]

@Mantux11 This needs an additional approval for the merge. Perhaps you can ping the people that have commented here but did not do a formal review.

[rafaelbn]

/ocabot migration stock_analytic

[rafaelbn]

I don't use this module. Ping my in 2 week if it not reviewed by other contributors. Thanks

[Mantux11]

@florenciafrigieri2 It's been a long time ago, when I tested this module, so personally, I forgot. If I will find, how and where, I will update this comment.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Mantux11]

@rafaelbn passed 2 weeks and PR has been approved. Could you review it and merge?

[grindtildeath]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-448-by-grindtildeath-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 1b17ae219649907f834d813abe16d2667a6d5e2d. Thanks a lot for contributing to OCA. ❤️