Roman Penyaev

Results 104 comments of Roman Penyaev

It seems my SDL event processing fix needs some massagging for SDL1. I'm looking into the SDL1.2 `SDL_PeepEvents()` implementation, which doesn't support an event type range but instead uses a...

> > but apparently this is not true, right? What am I missing here? > > Probably that there is no actual limitation as it's just a 32-bit integer in...

Oh, it's even worse, than just missing events. C17 standard (I assume same for all others, including CPP) says the following for bit shift: **6.5.7 Bitwise shift operators** *If the...

> It might help explain this. > > https://github.com/diasurgical/DevilutionX/blob/e57a2d7d54108973bc55249f4c4ccc44e475d03e/Source/interfac.cpp#L43-L48 Great there is an issue which can be explained by this. I was scratching my head, thinking it couldn't go unnoticed....

@StephenCWills @glebm thanks folks for helping me resolve the SDL1.2 issue. Now with only one type of custom event `SDL_PeepEvents()` logic becomes simpler. Am I correct that there is no...

Hey folks, just a quick reminder to review this PR when you get a chance! Thanks.

Anything else to address from my side or this can be merged?

Thanks @glebm for reviewing that.

> @NiteKat competition? Awesome! Eager to see the results, @NiteKat, please share.

> @rouming reading though your readme i would suggest making thing work coordinates relative to the player rather then absolute to the world. That makes it a lot closer to...