Dan Rose

Results 564 comments of Dan Rose

> That is not what is happening here. The colcon-bash package was simply developed with only Linux / macOS in mind. If you would like to use it on Windows...

Run this on a windows runner: https://github.com/rotu/colcon-cmake/actions/runs/224539412/workflow

Sure. Just edit a shell hook to have a syntax error and observe that there is no debug info to speak of. The Python stack trace here should be suppressed...

I may be naive. It seems that batch scripts don’t have “stack traces” as other languages do. The best solution for batch might just be to run the script with...

Oof. I dropped the ball here; converting to a draft. BTW, do you have a preference between `logger.exception(msg)` versus `logger.error(msg, exc_info=True)`?

I think colcon should continue to run further tests (unless `--abort-on-error` is true) and return a non-zero error code when it finishes. Possibly, it should add 1 to the error...

1. I think any exception other than a `SkipExtensionException` should cause an error message and a nonzero return code. Maybe *every* extension that returns True from `match()` should run. (btw,...

I don't know that I agree. It seems like one extension to run functional testing and another to run performance testing seems like a plausible use case. Or maybe a...

> It feels to me that you want to describe things in the most negative way possible - even if I comment in this thread extensively _why_ things are done...

Also updated the ticket to link to fix the link to the log.