Dan Rose

Results 564 comments of Dan Rose

I did my own implementation (below), before I realized you already wrote one. 1. The size of a limb is an implementation detail, not a feature. `RandomMode = Limbs` should...

@dlesnoff > You terribly missed my code motivation here. I wanted to have a helper function for the library development and unit testing first and foremost. I need to generate...

related issues: - https://github.com/wxWidgets/Phoenix/issues/2225 - https://github.com/wxWidgets/Phoenix/issues/2235 - https://github.com/wxWidgets/Phoenix/issues/2296

Your code is set up to call a function `__main__` in the module `pymavlink.tools.mavgen`. So it imports the `pymavlink.tools.mavgen` module (which has the side effect of running its code) and...

> If I knew what I was doing we wouldn't have these problems. Ha that’s such a familiar feeling to me… > Mavgen.py doesn't work on Windows? I'm not sure...

> No, the reason we're doing this is to allow mavgen.py to be called from anywhere following installation of pymavlink. That's what the new `console_scripts` entrypoint is for - it...

afaict, there was never a deliberate decision to break `python -m pymavlink.tools.mavgen` and it still will work (without #835) if you install the package in editable mode.

Closing my PR. This package needs much cleanup from someone who knows it better than me. I think pymavlink has too much technical debt right now to comfortably contribute. Something...