rostyslavtyshko
rostyslavtyshko
> Getting there, some small changes requested and a couple of questions. > > I'd also like to see the tests fleshed out some more. The existing tests could maybe...
> BTW, is there an issue for this? I didn't find one -- could be good to make one for reference so we can document motivating factors. Added one
> 1. I recommend chaning the syntax in the `From` trait for each type in addition to any `impl` that uses the name of the type rather than `Self` e.g....
> When requesting a review you should consider whether it is a draft or an open PR like this one. > > If it is an open PR then you...