Ross Moody comments

Results 9 comments of


Ross Moody

Export in next-gen formats that might even be better than PNG as far as file size, like WebP or AVIF.

Need to wait until Firefox 92 for AVIF: https://bugzilla.mozilla.org/show_bug.cgi?id=1682995

No style rules found on passed Component - Enzyme - styled()

I'm having a similar issue and this may not be related but I did notice you're missing a `'`. `import MyComponent from './MyComponent'`

Refactor patch for optimize_webui.py build script to use brave-specific file

Is there any reason why this PR might make it so you can't clear your history? I built this one working on my little icon side project and I can't...

Global CSS import

> I found a workaround by importing the css inside the `catalog/index.js`. > > ```js > import css from "./static/assets/css/global.css"; > ``` > > The way descriped inside the doc...

Support firefox / cross browser compatibility

I have no idea if this is bad practice so open to feedback, but I'm tinkering with programmatic v2 and v3 manifests in my extension. Wanted to share in case...

Remove the `removeViewBox` plugin from the default plugins list

I noticed this as I was working through [my little browser extension](https://github.com/rossmoody/svg-gobbler) that uses SVGO and thought it was odd. The default configuration made it much less dependable to scale...

Error: node_modules/@stitches/react/types"' has no exported member 'createStitches'

I noticed this error happened when I destructured the `config` object out of `createStitches`. If I left config out of destructure the error went away.

Export in next-gen formats that might even be better than PNG as far as file size, like WebP or AVIF.

This went out in 5.2!

Add translation for OK for notifications in wallet

I prob should have pinged first, I saw this one and it said "Fixes OK Translation" so I thought this was just out of date: https://github.com/brave/brave-core/pull/661