Andreas Rossberg comments

Results 956 comments of


                                            Andreas Rossberg

WebAssembly.{compile|instantiate}Streaming: what if embedder doesn't implement it?

Not sure how this is fundamentally different from other properties that are added by other APIs. For example, the DOM adds plenty of properties to the global object. Ecma-262 explicitly...

WebAssembly.{compile|instantiate}Streaming: what if embedder doesn't implement it?

@mtrofin, ah, okay, thanks for the clarification. And yes, I agree with the resolution.

Rust-like `include_str` macro

I have the same reaction as @nomeata: why would you embed frontend stuff like JS/HTML/CSS in Motoko? Motoko is for backend code, why conflate the two? As I just commented...

Re-wrapping with mismatched signatures

My understanding is that nothing special ought to happen in that case — the already wrapped inner function is treated as any old JS function. That simply results in the...

Unicode identifiers in the WAT format

> 1. Why are Unicode identifiers not allowed directly in the WebAssembly text format (i.e., string-escaping seems to be required)? Although web developers usually don't read them, devtools developers, Wasm...

[js-api] Throw in toResizableBuffer if memory has no max

@conrad-watt, can you please review this?

Change direction in wording around stack unwinding

The "up to" here is used in the sense of "up to some limit", not suggesting any stack direction.

Possible bug in spec of relaxeddotmul

~In fact, aren't the additions missing as well?~

Should there be a special case in assert_return for ref.null in the JS spec harness?

Yes, this appears to be an oversight. Would you be interested in creating a PR to fix it?

Should there be a special case in assert_return for ref.null in the JS spec harness?

Okay, I ported the internal test harness to sync/async, which had been out of date. This should work now, please let me know if there still are problems.