Ross Barnowski

Results 471 comments of Ross Barnowski

We're falling behind on these dependabot updates because we're blocked by the codecov bump. I'm going to go ahead and tell dependabot to ignore codecov so we can continue getting...

> From the logs of the workflow, i have tests failing for the docstrings examples in the cases of missing libraries such as scipy. This can be fixed by adding...

I'm not familiar with the development history of `complete_to_chordal_graph` either. My guess is the fact that `alpha` is structured as a dict was dictated by the implementation rather than any...

@tschoellhorn is this still an issue in nx v3.5? That should improve support for "dynamic" graphs in gexf but that may not have been the original issue. If you have...

As a start, could you provide a little background info on what this algorithm is/does? In what contexts is it useful? In your opinion, are there any similar algorithms in...

Thanks for the interesting background! I'm mostly trying to get a handle on whether it makes sense to present relatively straightforward functionality up under new user-facing terminology. If "linear geometric...

> Another big-picture question is "when does this stop being Girvan-Newman?" Are we forcing a new approach into an existing function? Or is it providing options for a small piece...

Thanks for reporting - this seems like a bug in the validator. I agree that `my_func_right` should be passing the validation.

> I tried adding a test for isolated nodes. But the test failed. Should I add a condition to handle isolated nodes? Or is there something I am missing here?...

If you want to keep the domain of the original polynomial, you should pass it in to `convert`, e.g. `Q = P.convert(domain=P.domain, kind=Polynomial)`. The current behavior is clearly documented and...