roshii

Results 50 comments of roshii

I will be working on this one next. I'm thinking at something similar to https://github.com/bitcoin/bitcoin/blob/master/doc/JSON-RPC-interface.md#security reusing/adapting `JMTokenAuthority` from https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1480 As far as I see it, authentication would be applied to...

for the record: I marked it as draft since I want to ensure users are properly notified - so far it is only printing a line to the logs

I did try to have this notification sent top UI but my frontend knowledge is pretty limited. Since I will not have enough time to investigate UI modification, I will...

@moneymanolis should be addressed. thanks for the detailed review

This would be a difficult one to reproduce. However, digging through code history we can explain this error as follows: `cryptoadvance.specter` depends on `flask-babel`, itself depending on `babel`. At the...

AFAIK, we could proceed as follows: 1. Calculate sha256sum for both source and wheel release during the `release_pip` CI step. ``` WHEEL_HASH=$(sha256sum cryptoadvance.specter-*.whl) SRC_HASH=$(sha256sum cryptoadvance.specter-*.tar.gz) echo "$WHEEL_HASH" > SHA256SUMS-pip echo...

this is solved by https://github.com/cryptoadvance/specter-desktop/pull/2255, isn't it?

AFAICT these three tasks are already implemented, therefore issue can be closed - unless I am missing something naturally.

> Are others experiencing the same with Python 3.12? Pretty sure it's not related to running Ubuntu under WSL. I did manage install `joinmarket` with Python 12 on Alpine Linux...

> While _setting_ config variables is arguably not security sensitive, _reading_ them certainly is! Because there may be (or may not) be rpc credentials for backend blockchain access written there....