Roshan Rajan

Results 8 comments of Roshan Rajan

@jeking3 Did you have any more feedback on this PR? Would love to have this! :D

@saimedhi Which is the preferred answer here? To only return a str or to support bytes?

I don't think there is necessary a compelling reason to support bytes, just that the code is confusing in that if bytes were passed to the serializer, then it would...

Yeah we can do this! But is `string_types` supposed to include bytes? Should it just be str?

Well it looks like the elasticsearch team supports bytes only for serializers - https://github.com/elastic/elastic-transport-python/blob/main/elastic_transport/_serializer.py so not sure how much you are keeping parity on the interfaces.

Didn't know about this doc but updated the repo with this and am still seeing the same errors - https://github.com/roshanjrajan-zip/face_recognition/commit/bae62a066eb62c853f2a6dac2aa927a8e486a770

@bschnurr Were you able to repro this problem?