rosbag2 icon indicating copy to clipboard operation
rosbag2 copied to clipboard

[WIP] The time bounded snapshot feature

Open MichaelOrlov opened this issue 1 year ago • 5 comments

This PR adds the "--snapshot-duration" CLI option.

The snapshot duration CLI option is specified as a floating point value in seconds. The default value 0.0 indicates that the snapshot will be limited by the --max-cache-size parameter only. If the value is more than 0.0, the cyclic buffer for the snapshot will be limited by both the series of messages duration and the maximum cache size parameter. To override the upper bound by total messages size, the --maximum-cache-size CLI option can be settled to 0.

  • Relates #900

MichaelOrlov avatar Oct 28 '24 02:10 MichaelOrlov

@reinzor I've made good progress on this PR. I would say I've made all the required changes for this feature. However, I didn't have time to test it and write unit tests.

The help here would be really appreciated. Feel free to cherry-pick commits from this PR or create a fork above it. Need to review https://github.com/ros2/rosbag2/pull/1844, test it locally, write unit tests, and update documentation.

MichaelOrlov avatar Nov 04 '24 01:11 MichaelOrlov

Is this still in development? It seems close to finished, what is blocking its merge?

ndmmdn avatar Jan 16 '25 17:01 ndmmdn

Sorry, did not have time to work on tests and testing this feature. Afaik that is what still is missing.

reinzor avatar Jan 16 '25 20:01 reinzor

Understood, thanks for the quick reply. Do you approximately know if/when you will be able to get to it?

ndmmdn avatar Jan 17 '25 08:01 ndmmdn

When this gets on our radar again and I have time to work on this. I cannot commit to a specific date.

reinzor avatar Jan 17 '25 08:01 reinzor