rosbag2 icon indicating copy to clipboard operation
rosbag2 copied to clipboard

Add changes to enable searching for .msg files in sub-directories

Open aditya2592 opened this issue 2 years ago • 4 comments

Fix for https://github.com/ros2/rosbag2/issues/1188

aditya2592 avatar Dec 19 '22 08:12 aditya2592

Failure in this test seems unrelated to the change in this PR

aditya2592 avatar Dec 29 '22 06:12 aditya2592

Are you able to add a test for this new behavior?

james-rms avatar Jan 02 '23 23:01 james-rms

Please include some equivalent of this patch to prevent the message definition cache mistaking CompressedImage.msg for Image.msg. Also, please add a test to this repo to ensure that this behavior is correct going forward.

Patch has been added. Is there any relevant documentation to compile and run tests in this repo? Or should I follow the normal colcon test process? Also is there a suggested test file to add it to?

aditya2592 avatar Jan 05 '23 23:01 aditya2592

test_message_definition_cache.cpp contains tests for this component, and includes several instances of searching for message definitions within the rosbag2_storage_mcap_testdata package. I'd recommend adding a nested subdirectory definition to the testdata package and testing that it can be found.

james-rms avatar Jan 06 '23 00:01 james-rms