rosbag2 icon indicating copy to clipboard operation
rosbag2 copied to clipboard

Store db schema version and ROS_DISTRO name in db3 files

Open MichaelOrlov opened this issue 2 years ago • 2 comments

  • Closes #1108

  • Relates #1086

  • Add new tables for schema and metadata

MichaelOrlov avatar Nov 10 '22 05:11 MichaelOrlov

@clalancette Could you please review this PR for ABI and API stability to be able to backport this PR to Humble?

MichaelOrlov avatar Nov 10 '22 06:11 MichaelOrlov

cc: @amacneil @defunctzombie

MichaelOrlov avatar Nov 10 '22 06:11 MichaelOrlov

Gist: https://gist.githubusercontent.com/MichaelOrlov/43376b9180367dfdbc6f83ac9e0b571f/raw/9de6d51acca2cd167442395b576ed59daa25d077/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_storage rosbag2_storage_sqlite3 rosbag2_tests TEST args: --packages-above rosbag2_storage rosbag2_storage_sqlite3 rosbag2_tests ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11164

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

MichaelOrlov avatar Nov 22 '22 20:11 MichaelOrlov

https://github.com/Mergifyio backport humble

MichaelOrlov avatar Nov 22 '22 22:11 MichaelOrlov

backport humble

✅ Backports have been created

mergify[bot] avatar Nov 22 '22 22:11 mergify[bot]

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-12-15/28840/1

ros-discourse avatar Dec 19 '22 18:12 ros-discourse