rosbag2 icon indicating copy to clipboard operation
rosbag2 copied to clipboard

[backport foxy] Add QoS decoding translation for infinite durations to RMW_DURATION_INFINITE (backport #684)

Open mergify[bot] opened this issue 2 years ago • 5 comments

This is an automatic backport of pull request #684 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

mergify[bot] avatar Sep 13 '22 20:09 mergify[bot]

Gist: https://gist.githubusercontent.com/emersonknapp/6b02a51c6326c1689d6f1745f25d064b/raw/0688bfd464a365c6b3a72397c58fc2512c2d6340/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_transport TEST args: --packages-above rosbag2_transport ROS Distro: foxy Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10813

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Rerun on focal

  • Linux Build Status
  • Linux-aarch64 Build Status

emersonknapp avatar Sep 15 '22 21:09 emersonknapp

Rerun CI for Windows

  • Windows Build Status

MichaelOrlov avatar Sep 21 '22 23:09 MichaelOrlov

It seems that CI Windows job failed to some glitches in infrastructure or race conditions in unit tets. Trying to rerun CI for Windows one more time:

  • Windows Build Status

MichaelOrlov avatar Sep 22 '22 18:09 MichaelOrlov

@emersonknapp It seems that TestRos2BagRecord.test_incomplete_qos_profile consistently fails on Windows CI Job.
And it looks like it somehow relates to the changes in this PR.
Can you please investigate this failure?

MichaelOrlov avatar Sep 22 '22 19:09 MichaelOrlov

Windows: Build Status

emersonknapp avatar Sep 29 '22 20:09 emersonknapp

Gist: https://gist.githubusercontent.com/MichaelOrlov/5b6d727b8a061123e96c0c58c3839d22/raw/0688bfd464a365c6b3a72397c58fc2512c2d6340/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_transport TEST args: --packages-above rosbag2_transport ROS Distro: foxy Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12101

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

MichaelOrlov avatar May 23 '23 23:05 MichaelOrlov

Rebuil on focal and without connext_dds BUILD args: --packages-above-and-dependencies rosbag2_transport TEST args: --packages-above rosbag2_transport ROS Distro: foxy Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12102

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

MichaelOrlov avatar May 23 '23 23:05 MichaelOrlov

Failure in the Windows CI job in ros2bag.test.test_record_qos_profiles.test_record_qos_profiles tests is unrelated to the changes from this PR and has been investigated in https://github.com/ros2/rosbag2/pull/1349.

MichaelOrlov avatar May 25 '23 17:05 MichaelOrlov

Re-run the Windows job one more time after rebase.

  • Windows Build Status

MichaelOrlov avatar May 25 '23 17:05 MichaelOrlov

The Linux job failed from the previous CI run due to the infrastructure issue related to the java.
However, the CI launcher automatically restarted those job and it passed green * Linux Build Status

Thanks @emersonknapp for teaching me how to find an automatically restarted CI job.

MichaelOrlov avatar May 25 '23 17:05 MichaelOrlov

Maybe let's wait for #1353 and then run one more clean CI on this one - though it looks like everything is OK here.

emersonknapp avatar May 25 '23 23:05 emersonknapp

@emersonknapp Ahh it will not be green anyway. There are a lot more warnings and random failures. This is like a nightmare. I want to wrap it up and forget.

MichaelOrlov avatar May 26 '23 06:05 MichaelOrlov