rosbag2
rosbag2 copied to clipboard
[service introspection] add syntactic sugar for recording services
This PR helps implements the proposed REP2012 https://github.com/ros-infrastructure/rep/pull/360 and adds a --service
or -S
option to ros2 bag record
to make it easier to record service events
Related issue: https://github.com/ros2/ros2/issues/1285
Signed-off-by: Brian Chen [email protected]
I'm just going to turn this into a draft PR for now so that this doesn't get merged in by accident before the ones it depends on gets merged in (Full list @ https://github.com/ros2/ros2/issues/1285#issuecomment-1209997582)
I just missed - it looks like you haven't signed a commit somewhere... I think it might be your initial commit.
Would you be able to sign that?
Ah yeah that would be from when I commited your suggestion from the web client...fixed now
- Closing in favor of #1414