ros2cli icon indicating copy to clipboard operation
ros2cli copied to clipboard

Published 20 hours ago • verified publisher icon ros2

support ros2 topic pub yaml file input

Open fujitatomoya opened this issue 1 year ago • 3 comments

closes https://github.com/ros2/ros2cli/issues/919

fujitatomoya avatar Aug 30 '24 05:08 fujitatomoya

@mjcarroll @clalancette @sloretz what do you think? this can be useful for test and development.

fujitatomoya avatar Aug 30 '24 05:08 fujitatomoya

CC: @ahcorde if you have time, can you take a look?

fujitatomoya avatar Sep 04 '24 16:09 fujitatomoya

This is a simplification of a rosbag, not sure about this feature, let's see what other people thing about it

yeah that is true.

the difference what i think of is, probably much easier to use and modify the data contents that are saved as yaml via ros2 topic echo. we have a chat about this in triage meeting, https://github.com/ros2/ros2cli/issues/919#issuecomment-2275893371 but yes lets get more feedback for this feature. see usage for https://github.com/ros2/ros2cli/pull/925#pullrequestreview-2271228846

CC: @Ryanf55 @mjcarroll @clalancette

fujitatomoya avatar Sep 05 '24 16:09 fujitatomoya

@clalancette @sloretz what do you think about this option? it would be really easier for user to update the data contents and publish it compared to rosbag2.

fujitatomoya avatar Nov 19 '24 01:11 fujitatomoya

We talked about this feature a bit in ROS PMC meeting today. after all feature makes sense, so i will keep this open for review.

@MichaelOrlov i do not think of the necessity to use rosbag2_py APIs here, what do you think?

fujitatomoya avatar Dec 03 '24 17:12 fujitatomoya

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-pmc-meeting-minutes-2024-12-03/40941/1

ros-discourse avatar Dec 03 '24 18:12 ros-discourse

@MichaelOrlov @clalancette thanks for the review and comments, i will address them soon.

fujitatomoya avatar Dec 08 '24 19:12 fujitatomoya

Pulls: ros2/ros2cli#925 Gist: https://gist.githubusercontent.com/fujitatomoya/5a498ad800e7b1dfa97f49c29afd8b27/raw/08a9f35c751b73a5ed630c8df618acf0fa32743b/ros2.repos BUILD args: --packages-above-and-dependencies ros2topic TEST args: --packages-above ros2topic ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14926

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya avatar Dec 09 '24 20:12 fujitatomoya

Pulls: ros2/ros2cli#925 Gist: https://gist.githubusercontent.com/fujitatomoya/76ff99794019cd2719103d04a39aac40/raw/08a9f35c751b73a5ed630c8df618acf0fa32743b/ros2.repos BUILD args: --packages-above-and-dependencies ros2topic TEST args: --packages-above ros2topic ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14927

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya avatar Dec 09 '24 21:12 fujitatomoya

@clalancette i have addressed your comments, and all tests are passing locally. can i have your approval?

fujitatomoya avatar Dec 09 '24 21:12 fujitatomoya

@clalancette @ahcorde can i have an approval either of you?

fujitatomoya avatar Feb 03 '25 21:02 fujitatomoya

Pulls: ros2/ros2cli#925 Gist: https://gist.githubusercontent.com/ahcorde/c7c617a575741538b5c0c5fa6ecb7ade/raw/f2d5d6ad5b722461450f91d2aecf19b59310172b/ros2.repos BUILD args: --packages-up-to ros2topic --packages-above-and-dependencies ros2topic TEST args: --packages-select ros2topic --packages-above ros2topic ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15135

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde avatar Feb 07 '25 14:02 ahcorde