ros2_documentation icon indicating copy to clipboard operation
ros2_documentation copied to clipboard

"Using parameters in a class" tutorials having inconsistent node names

Open jacobperron opened this issue 4 years ago • 1 comments

This is more of a nitpick, but the default names of the nodes in the parameter class tutorials are inconsistent. The C++ tutorials uses the name parameter_node and the Python tutorial uses the name param_talker.

I think the names should either be the same or follow the same pattern (i.e. both have the suffix _node or _talker).

Note, I noticed the inconsistency when adapting the launch file from the C++ tutorial that is referenced by the Python tutorial.

Links to tutorials:

  • https://index.ros.org/doc/ros2/Tutorials/Using-Parameters-In-A-Class-CPP
  • https://index.ros.org/doc/ros2/Tutorials/Using-Parameters-In-A-Class-Python

jacobperron avatar Jun 01 '20 23:06 jacobperron

Based on foxy version: In C++ the node name is "parameter_node" In Python the node name is 'minimal_param_node' I guess this is not a big issue, but agree to make them consistent

MorphyCao avatar Jul 06 '22 02:07 MorphyCao