ros2_documentation icon indicating copy to clipboard operation
ros2_documentation copied to clipboard

Add warning that actions require ament_cmake, not ament_python #4986

Open vimal0athithan opened this issue 8 months ago • 10 comments

vimal0athithan avatar Mar 30 '25 11:03 vimal0athithan

@Yadunund please check this

vimal0athithan avatar Mar 31 '25 16:03 vimal0athithan

Looks like @Yadunund and @fujitatomoya's suggestions are sufficient. I do want to point out that it helps us a lot if you can include a one or two sentence description of your pull request.

I just approved #5050 which should make #4985 a lot easier. Once you wrap up this PR you are more than welcome to give that one a try once you read my comment there.

kscottz avatar Apr 01 '25 22:04 kscottz

@vimal0athithan friendly ping. Can you accepted the suggestions and make the necessary changes please so we can get this out the door?

kscottz avatar Apr 07 '25 21:04 kscottz

@kscottz @Yadunund @fujitatomoya I have applied the suggested changes. Please review the updated version.

vimal0athithan avatar Apr 12 '25 16:04 vimal0athithan

@kscottz Thank you for the ping! I apologize for always contributing late always —I'm a university student, and my exams are currently ongoing, which has affected my availability. I’ve accepted the suggestions and made the necessary changes as requested. Please review the updates. Sorry again for the delay!

vimal0athithan avatar Apr 12 '25 16:04 vimal0athithan

@kscottz @Yadunund @fujitatomoya, I’ve pushed updates to fix the linting and test failures based on the check logs. Please review my new PR changes. Thank you!

vimal0athithan avatar Apr 16 '25 17:04 vimal0athithan

@kscottz @Yadunund @fujitatomoya, I’ve fixed the trailing whitespace and missing newline issues. Please review again. Thanks!

vimal0athithan avatar Apr 18 '25 11:04 vimal0athithan

@vimal0athithan can you hit the signoff / commit button on these?

kscottz avatar Apr 24 '25 21:04 kscottz

@vimal0athithan second ping. This is so close.

kscottz avatar May 01 '25 19:05 kscottz

@vimal0athithan friendly ping. We just have a couple of change requests to work through.

kscottz avatar May 08 '25 17:05 kscottz