ros2_documentation icon indicating copy to clipboard operation
ros2_documentation copied to clipboard

Update Custom-ROS2-Interfaces.rst

Open EliottFerry opened this issue 1 year ago • 2 comments

Changing python codeblock to match previous AddThreeInts implementation (C++ might need a check also, i followed only the Python tutorial)

EliottFerry avatar Oct 04 '24 12:10 EliottFerry

@EliottFerry can you clarify what you mean by, "match previous AddThreeInts implementation."

kscottz avatar Oct 04 '24 18:10 kscottz

@kscottz Of course, on this step, you have the implementation of MinimalClientAsync along with a main function. This main implementation does not match with this implementation, where some error handling is being implemented, without the #CHANGE tags showing the line that as been changed. I got "confused" reaching this step, since I did not understood why the main function had changed that much. Maybe the second implementation should be the one to be kept to give an example of error handling.

EliottFerry avatar Oct 04 '24 19:10 EliottFerry