ros2_documentation icon indicating copy to clipboard operation
ros2_documentation copied to clipboard

move RTI Connext DDS installation doc under Install-Connext-Universit…

Open fujitatomoya opened this issue 1 year ago • 4 comments
trafficstars

…y-Eval.

closes https://github.com/ros2/ros2_documentation/issues/3573

fujitatomoya avatar Sep 24 '24 14:09 fujitatomoya

@clalancette @ahcorde what do you think about this?

fujitatomoya avatar Sep 24 '24 14:09 fujitatomoya

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12758777595/artifacts/2425555939.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4774/index.html in your favorite browser

github-actions[bot] avatar Sep 24 '24 15:09 github-actions[bot]

@ahcorde thanks for the review. let's hold this to merge for now, i would like @clalancette 's review comment on this.

fujitatomoya avatar Sep 24 '24 22:09 fujitatomoya

@clalancette can you take a look when you have time?

fujitatomoya avatar Oct 01 '24 18:10 fujitatomoya

@clalancette @audrow what do you think about this doc structure change for RTI connext DDS?

fujitatomoya avatar Dec 01 '24 23:12 fujitatomoya

Minor comment aside, I personally think this makes a lot of sense.

christophebedard avatar Dec 02 '24 17:12 christophebedard

@christophebedard @ahcorde it should be good now! requesting another review on https://github.com/ros2/ros2_documentation/pull/4774/commits/4e08766173adb1e0bf49fca1e8ce780f93e838a3

fujitatomoya avatar Jan 14 '25 00:01 fujitatomoya