ros2_documentation icon indicating copy to clipboard operation
ros2_documentation copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Add ParameterDescriptor to 'Using parameters in a class (C++)'

Open chianfern opened this issue 3 years ago • 3 comments
trafficstars

Closes #784: Adds section on how to use ParameterDescriptor for the C++ tutorial.

Also closes #729.

chianfern avatar Jul 12 '22 06:07 chianfern

@chianfern

thanks for the contribution, can you address test failure? https://github.com/ros2/ros2_documentation/runs/7332086463?check_suite_focus=true

fujitatomoya avatar Jul 14 '22 01:07 fujitatomoya

@fujitatomoya Thanks for the review! I've fixed the test failure.

chianfern avatar Jul 19 '22 01:07 chianfern

@clalancette friendly ping.

fujitatomoya avatar Jul 20 '22 06:07 fujitatomoya

Just as an FYI, I went in here and cleaned up the tutorials in question pretty heavily. In particular, I made sure that the C++ and Python versions were as alike as possible, including the code and the language around them. With all of that in place, I'm now happy with this, so I'm going to approve and merge. Thanks for the contribution!

clalancette avatar Oct 18 '22 13:10 clalancette