ros1_bridge icon indicating copy to clipboard operation
ros1_bridge copied to clipboard

[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg

Open ColinChargyPro opened this issue 2 weeks ago • 0 comments

This PR adds --fix-ros2-names CLI arg to automatically modify topic name which starts with a number (because it's invalid for ROS2 topic). ROS1 would allow names like "/lidar/bottom/1_2v" but ROS2 wouldn't:

terminate called after throwing an instance of 'rclcpp::exceptions::InvalidTopicNameError'
  what():  Invalid topic name: topic name token must not start with a number:
  '/lidar/bottom/1_2v'

This PR adds an underscore so the modified topic name would be valid in ROS2 ("" in the example)

ColinChargyPro avatar Feb 04 '25 10:02 ColinChargyPro