rmw_implementation icon indicating copy to clipboard operation
rmw_implementation copied to clipboard

change rmw_implementation deps to be buildtool and not exec

Open wjwwood opened this issue 5 years ago • 6 comments

Discovered this while going over dependencies again with @chapulina. I think it should be build tool and not exec.

wjwwood avatar May 01 '20 18:05 wjwwood

Can you reorder these two new lines to follow the schema order ?

ahcorde avatar May 01 '20 20:05 ahcorde

How do you mean? I think they are in that order? Do you mean move them above the lines around them? This package already has a mixture of depend and other tags, so I didn't try to reorder everything.

wjwwood avatar May 01 '20 21:05 wjwwood

@wjwwood What is the status on this?

dirk-thomas avatar Jun 15 '20 05:06 dirk-thomas

Sorry, this fell through the cracks. When you poked me originally, I hesitated to merge it now because I was worried it shouldn't go into foxy. But I can merge it and then decide if we should back port it. Any thoughts on if it should be back ported?

wjwwood avatar Jun 25 '20 17:06 wjwwood

From a Debian point of view this is a no-op and (to my knowledge) we nowhere use these dependency types differently anywhere else. Therefore I don't mind if it does get backported or not.

dirk-thomas avatar Jun 25 '20 17:06 dirk-thomas

@ahcorde can you re-review this?

wjwwood avatar Jun 25 '20 17:06 wjwwood