rmw_connextdds icon indicating copy to clipboard operation
rmw_connextdds copied to clipboard

should return if CONNEXTDDS_ARCH is not set after guessing

Open asobhy-qnx opened this issue 3 years ago • 1 comments

https://github.com/ros2/rmw_connextdds/blob/46b23ca3ca718ab4c624898b1e543b0b3e57000d/rti_connext_dds_cmake_module/cmake/rti_build_helper.cmake#L562

should be:

        if(NOT CONNEXTDDS_ARCH)
          rti_guess_connextdds_arch()
          if(NOT CONNEXTDDS_ARCH)
            return()
          endif()
        endif()

asobhy-qnx avatar Aug 20 '21 15:08 asobhy-qnx

Hi @asobhy-qnx,

Thank you for your suggestion! The change makes sense to me, since at the moment the build will "fall through" without a CONNEXTDDS_ARCH value, and fail more subtly at a later point.

I'll try to update the build files soon, but feel free to open a PR on the repository if you want/have the bandwidth. Community contributions are always welcome 😄

asorbini avatar Sep 01 '21 01:09 asorbini