rcutils icon indicating copy to clipboard operation
rcutils copied to clipboard

Published 20 hours ago • verified publisher icon ros2

use strnlen_s instead of strnlen if available

Open razr opened this issue 2 years ago • 5 comments

use strnlen_s instead of strnlen if available. VxWorks has only strnlen_s

razr avatar Sep 18 '23 09:09 razr

@razr thanks for the PR, DCO is failing. could you address it with comments?

fujitatomoya avatar Sep 18 '23 17:09 fujitatomoya

Sorry, I've missed the DSO, will update it. Thank you for pointing it out.

razr avatar Sep 18 '23 19:09 razr

I ended up implementing this with memchr in 6349f20 . @razr Can you take a look and see if this will work for you on VxWorks?

clalancette avatar Nov 07 '23 22:11 clalancette

@clalancette it works on VxWorks. LGTM.

razr avatar Nov 28 '23 12:11 razr

@clalancette it works on VxWorks. LGTM.

All right, sounds good. Can you please rebase this PR and add a Signed-off-by line to your commit? Once that is done, I'll rebase this on the latest and run CI.

clalancette avatar Nov 28 '23 13:11 clalancette