rclpy icon indicating copy to clipboard operation
rclpy copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Support wait for message backport humble

Open fujitatomoya opened this issue 1 year ago • 9 comments
trafficstars

This is the backport of the following PRs. (conflicts are resolved already)

  • https://github.com/ros2/rclpy/pull/960
  • https://github.com/ros2/rclpy/pull/1180

backport is originally requested here, https://github.com/ros2/rclpy/issues/1179

note, this is purely adding a new method, this does not break API nor user application behavior.

fujitatomoya avatar Apr 21 '24 23:04 fujitatomoya

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya avatar Apr 21 '24 23:04 fujitatomoya

LGTM

Barry-Xu-2018 avatar Apr 22 '24 05:04 Barry-Xu-2018

I added an option to specify the qos: https://github.com/ros2/rclpy/pull/1225/files

I would make this part of this backport.

Timple avatar Apr 22 '24 06:04 Timple

rmw_connextdds_common build failed, i am not sure why.

fujitatomoya avatar Apr 22 '24 16:04 fujitatomoya

rmw_connextdds_common build failed, i am not sure why.

Ah, the build needs to specify humble (for the ROS_DISTRO) and jammy (for the UBUNTU_DISTRO)

clalancette avatar Apr 22 '24 16:04 clalancette

@clalancette thanks, my bad... 😓

fujitatomoya avatar Apr 22 '24 16:04 fujitatomoya

@Timple i will manage https://github.com/ros2/rclpy/pull/1225/files and retry CI.

fujitatomoya avatar Apr 22 '24 16:04 fujitatomoya

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya avatar Apr 22 '24 17:04 fujitatomoya

https://ci.ros2.org/job/ci_windows/21567/ is unrelated.

@clalancette can we merge this?

fujitatomoya avatar Apr 24 '24 20:04 fujitatomoya

This is actually the backport fix, since CI is green, i will go ahead to merge this.

fujitatomoya avatar Jun 25 '24 05:06 fujitatomoya