rclpy icon indicating copy to clipboard operation
rclpy copied to clipboard

Add parallel callback test

Open Flova opened this issue 3 years ago • 1 comments

Following up on the suggestion in #1039, this pull request adds a test case which checks if the parallel processing of callback is working when the reentrant callback group and the multithreaded executor are used. This behavior was broken recently, and the test should ensure that future regressions are noticed.

The test case is based on the reproduction example from #1039. I put it together with the callback group test cases, but we could put it somewhere else.

Flova avatar Nov 18 '22 10:11 Flova

@fujitatomoya ping :)

Flova avatar Nov 18 '22 10:11 Flova

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya avatar Nov 29 '22 07:11 fujitatomoya

@fujitatomoya I added your suggestions.

Flova avatar Nov 29 '22 15:11 Flova

@adityapande-1995 can you review this?

fujitatomoya avatar Nov 30 '22 19:11 fujitatomoya

@Mergifyio backport to humble

fujitatomoya avatar Dec 02 '22 17:12 fujitatomoya

backport to humble

✅ Backports have been created

mergify[bot] avatar Dec 02 '22 17:12 mergify[bot]