Release ownership of entities after spinning cancelled (backport #2556)
This issue was found in ros2/rmw_fastrtps#761.
In code of MoveIt, it used static executor. When the static executor is destructed (The executor is in a cancel state.), and it's time to free up the ownership of entity resources, Fast DDS resources have already been released.
After spinning is cancelled, the Executor should release ownership of entities at once.
This is an automatic backport of pull request #2556 done by Mergify.
Cherry-pick of 069a0018935b33a14632a1cdf4074984a1cf80fe has failed:
On branch mergify/bp/jazzy/pr-2556
Your branch is up to date with 'origin/jazzy'.
You are currently cherry-picking commit 069a0018.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: rclcpp/src/rclcpp/executor.cpp
modified: rclcpp/src/rclcpp/executors/multi_threaded_executor.cpp
modified: rclcpp/src/rclcpp/executors/single_threaded_executor.cpp
modified: rclcpp/test/rclcpp/CMakeLists.txt
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: rclcpp/test/rclcpp/executors/test_executors.cpp
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
i think this fix should be backported to jazzy, but git found conflict. could you resolve that?
Okay. I will fix it.
Looks like the Linux runner filled up:
10:29:37 [2738.025s] ERROR:colcon.colcon_core.event_reactor:Exception in event handler extension 'event_log': [Errno 28] No space left on device [log/build_2024-07-10_09-44-14/events.log]
10:29:52 [2738.025s] ERROR:colcon.colcon_core.event_reactor:Exception in event handler extension 'event_log': [Errno 28] No space left on device [log/build_2024-07-10_09-44-14/events.log]
10:29:52 [2738.026s] ERROR:colcon.colcon_core.event_reactor:Exception in event handler extension 'event_log': [Errno 28] No space left on device [log/build_2024-07-10_09-44-14/events.log]
10:29:52 [2738.094s] ERROR:colcon.colcon_core.event_reactor:Exception in event handler extension 'event_log': [Errno 28] No space left on device [log/build_2024-07-10_09-44-14/events.log]
10:29:52 [2738.095s] ERROR:colcon.colcon_core.event_reactor:Exception in event handler extension 'event_log': [Errno 28] No space left on device [log/build_2024-07-10_09-44-14/events.log]
10:29:52 [2738.097s] ERROR:colcon.colcon_core.event_reactor:Exception in event handler extension 'event_log': [Errno 28] No space left on device [log/build_2024-07-10_09-44-14/events.log]
10:29:52 [2738.198s] ERROR:colcon.colcon_core.event_reactor:Exception in event handler extension 'event_log': [Errno 28] No space left on device [log/build_2024-07-10_09-44-14/events.log]
The reason for the test failure for Linux-aarch64 is
mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'