ros2
Added test cased for missing events & double call to take_data
Added a test, if a trigger event for a waitable was missed. Added a test, if take_data was called two times in a row, without calling is_ready in between. This is related to #2250.
@mjcarroll here is the merge request for the tests. Note, one of them currently fails !
I got knocked out by a cold, I will take a look at this when I 'm recovered.
I reworked the double take data test, it works not on the 'standard' multithreaded executor, showing the race that was introduces with https://github.com/ros2/rclcpp/pull/2109
I think we ca drop this PR. We came to the conclusion, that loss events is intended, and its up the the waitables to deal with this. @wjwwood did a PR for this, so we should be fine on that front.
As for the double take data, the test was very specific to the old implementation, as the timing needed to be right for the test to trigger. The bug has also been fixed in jazzy / rolling, so I think its save to drop the test as well.