rcl icon indicating copy to clipboard operation
rcl copied to clipboard

call rcl content filter fallback

Open iuhilnehc-ynos opened this issue 2 years ago • 5 comments

  • [ ] https://github.com/ros2/rcl_content_filter_fallback/pull/1
  • [ ] https://github.com/ros2/rcl/pull/996 (current PR)
  • [ ] https://github.com/ros2/rmw_fastrtps/pull/672
  • [ ] https://github.com/ros2/rmw_connextdds/pull/106
  • [ ] https://github.com/ros2/rmw_implementation/pull/217
  • [ ] https://github.com/ros2/demos/pull/579

Signed-off-by: Chen Lihui [email protected]

iuhilnehc-ynos avatar Aug 01 '22 04:08 iuhilnehc-ynos

@clalancette @wjwwood about fallback filtering in rcl, that requires new repository https://github.com/ros2/common_content_filter/pull/1, I will be working on the review. but i think it would not be probable to integrate new repo for Iron FF? what do you think? if you have any better ideas, please let us know.

fujitatomoya avatar Feb 15 '23 06:02 fujitatomoya

Try CI for 6 PRs mentioned in https://github.com/ros2/rcl/pull/996#issue-1323805337

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

iuhilnehc-ynos avatar Mar 01 '23 05:03 iuhilnehc-ynos

rerun CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

iuhilnehc-ynos avatar Mar 02 '23 08:03 iuhilnehc-ynos

Give it another shot.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

iuhilnehc-ynos avatar Mar 06 '23 02:03 iuhilnehc-ynos

@fujitatomoya

You're right. we should not let users know something about DDS information in RCL layer, even if the DDS characters.

iuhilnehc-ynos avatar Mar 08 '23 02:03 iuhilnehc-ynos