rcl Added remapping resolution for action names

Currently remapping of action names is not possible see https://github.com/ros2/ros2/issues/1312 . I have now stumbled over this multiple times and I think it is a useful feature, so i took a shot at implementing the remapping of action names. Please let me know if you have any comments or if I overlooked something. Fixes https://github.com/ros2/ros2/issues/1312.

Jul 16 '24 14:07 JustusBraun

I wasn't able to reproduce the test error locally. I think this might be related to/the same as https://github.com/ros2/rcl/issues/1016.

Jul 22 '24 13:07 JustusBraun

I have added tests for action name remapping as requested. @fujitatomoya do you think it is necessary to add tests for local arguments passed to rcl_node_init also?

Jul 27 '24 11:07 JustusBraun

Hi, I was was busy for some time and forgot about this PR.

As far as I understand the errors, they are not related to my changes. There seem to be a lot of unexpected 'test_broadcaster_xy' nodes in the test environment of the rcl and projectroot test suites.

Sorry for leaving this pr stale for so long.

Jan 03 '25 21:01 JustusBraun

@Mergifyio rebase

Jan 17 '25 19:01 fujitatomoya

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/6)
Auto-merging rcl_action/src/rcl_action/action_client.c
CONFLICT (content): Merge conflict in rcl_action/src/rcl_action/action_client.c
Auto-merging rcl_action/src/rcl_action/action_server.c
Auto-merging rcl_action/test/rcl_action/test_action_server.cpp
error: could not apply 44dcad3... Added remapping resolution for action names
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 44dcad3... Added remapping resolution for action names

Jan 17 '25 19:01 mergify[bot]

@JustusBraun can you rebase this? i tried that via Mergifyio but failed.

Jan 17 '25 19:01 fujitatomoya

@fujitatomoya done! Locally all test passed with colcon test

Jan 18 '25 08:01 JustusBraun

@Barry-Xu-2018 requesting review on this.

Jan 22 '25 17:01 fujitatomoya

@fujitatomoya I have added the tests with local arguments.

Jan 23 '25 18:01 JustusBraun

Pulls: ros2/rcl#1170 Gist: https://gist.githubusercontent.com/fujitatomoya/95f8ba959cca7319c9b6361710516c9c/raw/a56ce747ca67db7c529e958e565a96bd29f8a77f/ros2.repos BUILD args: --packages-above-and-dependencies rcl_action TEST args: --packages-above rcl_action ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15086