Add yaml tag full support.

[llapx]

Signed-off-by: Lei Liu [email protected]

[fujitatomoya]

@llapx do we have related issue for this? i think we had discussion on supporting yaml tag before, but cannot find the one.

[llapx]

@fujitatomoya

https://github.com/ros2/rcl/issues/1026

[llapx]

Can anybody help to handle this Failed ?

>>> [rcutils|error_handling.c:108] rcutils_set_error_state()
This error state is being overwritten:

  'Sequence should be of same type. Value type 'bool' do not belong at line_num 1, at /tmp/ws/src/rcl/rcl_yaml_param_parser/src/parse.c:313'

I have tried without this PR (in local), but the error still exist.

[Barry-Xu-2018]

I just quick check.
About test, whether incorrect configuration test need to be added ?

[Barry-Xu-2018]

I have tried without this PR (in local), but the error still exist.

I run rcl test with latest codes in my local environment. Not find this problem.
Commit b9de17458e5f359368257a2f0608c7031d607595 for rcl repository.

[llapx]

I just quick check. About test, whether incorrect configuration test need to be added ?

This lead to bool res = rcl_parse_yaml_file(path, params_hdl); return False, the error info looks like bellow:

3: [ RUN      ] test_parser.correct_syntax
3: /work/rcl_issues_1026/src/rcl/rcl_yaml_param_parser/test/test_parse_yaml.cpp:53: Failure
3: Value of: res
3:   Actual: false
3: Expected: true
3: Error parsing value hello at line 76, at /work/rcl_issues_1026/src/rcl/rcl_yaml_param_parser/src/parse.c:276
3: [  FAILED  ] test_parser.correct_syntax (0 ms)
3: [----------] 1 test from test_parser (0 ms total)

which may not easy to check.

[llapx]

@clalancette @fujitatomoya

Can you have a review?

[Barry-Xu-2018]

@ahcorde

I'll take over this. Considering that no one has requested full YAML support at the moment, I plan to put this PR on hold for now. Could you change the status to draft and assign to me?