launch_ros icon indicating copy to clipboard operation
launch_ros copied to clipboard

Published 20 hours ago • verified publisher icon ros2

support wildcards

Open iuhilnehc-ynos opened this issue 1 year ago • 3 comments

to address https://github.com/ros2/rclcpp/issues/1265#issuecomment-1620208946

iuhilnehc-ynos avatar Jul 13 '23 02:07 iuhilnehc-ynos

hey @iuhilnehc-ynos, thanks for working on this! is this ready? I could give it a quick test for my application and give feedback

tonynajjar avatar Jul 25 '23 08:07 tonynajjar

@tonynajjar I have some other PRs in my hand. I suppose that another one, which was pushed before this PR, will be reviewed in the coming days. Therefore, I marked this PR as a draft.

I would appreciate it if you could give it a try. Any feedback is welcome.

iuhilnehc-ynos avatar Jul 25 '23 09:07 iuhilnehc-ynos

I'm on Humble so I just copied your changes to to_parameters_list.py and that did the trick! With this PR, my composable node was able to read a yaml file as such:

/**:
  controller_server:
    ros__parameters:
      speed_limit_topic: "speed_limit"
      odom_topic: odometry/filtered
      ....

  behavior_server:
    ros__parameters:
      costmap_topic: local_costmap/costmap_raw
      footprint_topic: local_costmap/published_footprint
      ......

tonynajjar avatar Jul 25 '23 13:07 tonynajjar