launch icon indicating copy to clipboard operation
launch copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Use yaml types

Open InvincibleRMC opened this issue 1 year ago • 5 comments
trafficstars

I notice yaml was given a #type: ignore but that is no longer necessary with python3-types-pyaml

InvincibleRMC avatar May 22 '24 19:05 InvincibleRMC

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya avatar Jun 06 '24 18:06 fujitatomoya

@InvincibleRMC can you address https://ci.ros2.org/job/ci_linux/21236/testReport/junit/launch.test/test_mypy/test_mypy/?

fujitatomoya avatar Jun 06 '24 19:06 fujitatomoya

Strange it cannot find types-pyaml error: Library stubs not installed for "yaml" [import-untyped]

InvincibleRMC avatar Jun 06 '24 20:06 InvincibleRMC

Hmm I might be wrong but looking at this we might need to add the install in ros2ci itself.

InvincibleRMC avatar Jun 06 '24 20:06 InvincibleRMC

Made a pr over at https://github.com/ros2/ci/pull/781 to hopefully address this problem.

InvincibleRMC avatar Jun 06 '24 20:06 InvincibleRMC

Pulls: ros2/launch#781 Gist: https://gist.githubusercontent.com/ahcorde/ac8fcb3e691f7fbe969fdf43a50dafa7/raw/a7b2958f8e8df18cc7ce96339b36b947ea69e336/ros2.repos BUILD args: --packages-above-and-dependencies launch TEST args: --packages-above launch ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17187

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde avatar Oct 03 '25 13:10 ahcorde