launch icon indicating copy to clipboard operation
launch copied to clipboard
verified publisher icon ros2

python expressions substitution include names of all parents for specified modules

Open zflat opened this issue 3 years ago • 4 comments

This updates the python expression substitution to help with specifying python modules that are within a package.

Addresses issue https://github.com/ros2/launch/issues/687

zflat avatar Jan 12 '23 20:01 zflat

@adityapande-1995 Can I please get a review?

zflat avatar Jun 29 '23 01:06 zflat

Overall, I think this change is valuable. I've left one thing to change, but once that is fixed I think we can run CI on it.

Thanks @clalancette for the fix to the copy & paste error. Much better to have an appropriate failure reason reported.

zflat avatar Aug 15 '23 03:08 zflat

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette avatar Aug 22 '23 12:08 clalancette

So it looks like this caused a hang in the launch tests on all platforms. @zflat Can you take a look? It may the case that this just needs a rebase, but also please try to run the tests locally and make sure that they pass.

clalancette avatar Aug 23 '23 12:08 clalancette