launch icon indicating copy to clipboard operation
launch copied to clipboard

Improve launch file parsing error messages

Open timonegk opened this issue 3 years ago • 2 comments

This pull request improves the parsing error messages for launch files in two ways:

  1. Parser errors clearly show that values are substituted and not part of the error message itself. I was recently confused by a message Attribute value of type <class 'str'> not found in Entity let, not realizing that the attribute "value" was missing and not some kind of "attribute value".
  2. On an InvalidLaunchFileError, all parsing errors are logged.

timonegk avatar Jul 12 '22 06:07 timonegk

@ros-pull-request-builder retest this please

audrow avatar Aug 17 '22 21:08 audrow

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

audrow avatar Aug 17 '22 21:08 audrow

@audrow friendly ping

timonegk avatar Mar 01 '23 09:03 timonegk

@audrow ping

timonegk avatar Jul 04 '23 13:07 timonegk

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette avatar Jul 04 '23 17:07 clalancette

I rebased this onto the latest. Here is another CI run:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette avatar Jul 04 '23 18:07 clalancette

CI again after flake8 fix:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette avatar Jul 05 '23 15:07 clalancette