geometry2 icon indicating copy to clipboard operation
geometry2 copied to clipboard

reuse logic from Time::durationToSec method

Open dirk-thomas opened this issue 6 years ago • 2 comments

As suggested in https://github.com/ros2/rclcpp/pull/536#discussion_r211035479 the logic could be moved to rcutils and be used in rclcpp::Time and rclcpp::Duration.

dirk-thomas avatar Aug 21 '18 16:08 dirk-thomas

I can open up a PR for this since it's a simple logic movement but I would assume it would make more sense to move the logic to rclcpp opposed to rcutils to keep rcutils concise. Does anybody else have any opinions on where it should be moved to?

CursedRock17 avatar Mar 29 '24 03:03 CursedRock17

I can open up a PR for this since it's a simple logic movement but I would assume it would make more sense to move the logic to rclcpp opposed to rcutils to keep rcutils concise.

I don't think we can do that. The problem is that tf2 does not, and cannot, depend on rclcpp. However, both tf2 and rclcpp currently depend on rcutils, so that is a logical place to share the implementation.

clalancette avatar Apr 03 '24 20:04 clalancette