geometry2 icon indicating copy to clipboard operation
geometry2 copied to clipboard

[tf2] Output canTransform msg only on state change

Open aprotyas opened this issue 3 years ago • 2 comments

The "frame does not exist" error message in BufferCore::validateFrameId is noisy and not warranted if a frame never existed to begin with, so that message is only outputted once a state change has occurred - i.e. any frame was found.

Fixes https://github.com/ros2/geometry2/issues/358.

Signed-off-by: Abrar Rahman Protyasha [email protected]

aprotyas avatar Dec 27 '21 20:12 aprotyas

It's been a while since I've done this... can anyone run CI please?

aprotyas avatar Dec 06 '22 19:12 aprotyas

Gist: https://gist.githubusercontent.com/emersonknapp/db372988ab86273a8125101ee006afb5/raw/e4913ecebdf892a47f59a89cb0cafa3265432f5a/ros2.repos BUILD args: --packages-above-and-dependencies tf2 TEST args: --packages-above tf2 ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11230

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

emersonknapp avatar Dec 06 '22 22:12 emersonknapp