common_interfaces reapply yuv encoding deprecation

This reapplies https://github.com/ros2/common_interfaces/pull/247 with fixes for MSVC.

With https://github.com/ros2/rviz/pull/1276 there are no references to the deprecated encodings yuv422 or yuv422_yuy2 left in the core packages (https://github.com/ros2/ros2/blob/rolling/ros2.repos).

Requires:

[x] https://github.com/ros2/rviz/pull/1276

Sep 08 '24 10:09 christianrauch

Linux
Linux-aarch64
Linux-rhel
Windows

Sep 09 '24 08:09 ahcorde

I'm going to be perfectly frank; I'm not sure that this is worth putting in. The simple fact is that these encodings are not standardized anywhere. And I am fine having two aliases for the same thing. Finally, this PR adds in a lot of #ifdef cruft. The combination of all of these things says to me that this is making work for not a lot of gain.

That said, this is just my opinion, and I'm not going to fight hard for it. If others think that this is much clearer, then I'm not going to put up a fuss about it.

Sep 09 '24 13:09 clalancette

@ahcorde With https://github.com/ros2/rviz/pull/1276 now merged, can you run the CI again?

Oct 03 '24 11:10 christianrauch

@ahcorde Can you run the CI again?

Nov 22 '24 22:11 christianrauch

Pulls: ros2/common_interfaces#257 Gist: https://gist.githubusercontent.com/ahcorde/3c3c497d78d15771820e5f1fe05e4d21/raw/ed0296b88c82fce76a31bf4360771600ef5803e1/ros2.repos BUILD args: --packages-above-and-dependencies common_interfaces --packages-above-and-dependencies common_interfaces TEST args: --packages-above common_interfaces --packages-above common_interfaces ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14885

Linux
Linux-aarch64
Linux-rhel
Windows

Dec 02 '24 09:12 ahcorde

@tfoote @mjcarroll @ahcorde Can you have a look at this PR again, please? I had to rebase, but it should still pass all the OS configurations.

Feb 26 '25 07:02 christianrauch