cartographer_ros icon indicating copy to clipboard operation
cartographer_ros copied to clipboard

Port assets_writer to ROS2

Open chargerKong opened this issue 3 years ago • 4 comments

#47 Add assets_writer_node which can be called by

ros2 run cartographer_ros assets_writer_node \
-configuration_directory=xxx \
-configuration_basename=xxx.lua\
-bag_filenames=xxx\
-pose_graph_filename=xxx.pbstream\
-output_file_prefix=xxx\
-urdf_filename=xxx

where urdf_filename is optional

This code is tested in foxy, so I submit it to ros2 branch

chargerKong avatar Nov 05 '21 17:11 chargerKong

Hi @clalancette, the CI error shows the packages "rosbag2_cpp" and "urdf" can not be found.

I’m not sure if the ROS index page, urdf and rosbag2_cpp has indicated that these two packages have been already been released in rolling

If so, should it be reinstalled, If not, which branch should I submit to?

chargerKong avatar Nov 05 '21 18:11 chargerKong

Friendly ping @clalancette

chargerKong avatar Nov 08 '21 06:11 chargerKong

This can be probably closed as the asset_writer has also been ported in the recent v2 merge

doisyg avatar Apr 29 '22 09:04 doisyg

Yes, that is a good point. The only reason to keep this open would be to merge it onto the Galactic/Foxy branches. @chargerKong are you interested in having it there?

clalancette avatar Apr 29 '22 11:04 clalancette