buildfarm_perf_tests icon indicating copy to clipboard operation
buildfarm_perf_tests copied to clipboard

add CycloneDDS to Two Processes Test Results

Open joespeed opened this issue 4 years ago • 4 comments

Please add CycloneDDS to the following tests:

CycloneDDS is already included in the following tests:

rmw_cyclonedds is already in all tests. @cottsay @dirk-thomas @eboasson @k0ekk0ek http://build.ros2.org/job/Fci__nightly-performance_ubuntu_focal_amd64/plot/

joespeed avatar Oct 30 '20 22:10 joespeed

Here is the spot that needs to change (be removed) for this to happen: https://github.com/ros2/buildfarm_perf_tests/blob/bc4e0028b5bc0fdd15df1db53ed13ed00801afb7/test/CMakeLists.txt#L97-L103

Has the referenced issue been resolved? Is that fix released for Foxy or Eloquent as well?

cottsay avatar Oct 30 '20 22:10 cottsay

@cottsay thank you for the insight, we will check that @eboasson @k0ekk0ek

joespeed avatar Oct 30 '20 22:10 joespeed

It appears that this is still not implemented in performance_test, so we can't do anything about it here. When the situation changes, we can remove the "skip" flags here to enable the tests you want.

https://gitlab.com/ApexAI/performance_test/-/blob/master/performance_test/src/communication_abstractions/cyclonedds_communicator.hpp#L186-188

I think the best thing to do would be to track this on the Apex.AI repository, since that is where the feature needs to be implemented.

cottsay avatar Oct 30 '20 22:10 cottsay

Has anyone noticed my PR?

y-okumura-isp avatar Dec 15 '20 05:12 y-okumura-isp