urdfdom_headers icon indicating copy to clipboard operation
urdfdom_headers copied to clipboard
verified publisher icon ros

Fix assumption that CMAKE_INSTALL_*DIR paths are relative.

Open lopsided98 opened this issue 5 years ago • 2 comments

The CMAKE_INSTALL_*DIR variables are allowed to contain absolute paths according to the CMake documentation. This PR fixes the handling of these absolute paths while retaining the current behavior if they are relative. I also fixed the hardcoded includedir in the pkg-config file.

See https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-path for more information about this problem.

lopsided98 avatar Jul 06 '20 05:07 lopsided98

I fixed the conflicts and tested the updated patch. I would appreciate getting this reviewed, since we depend on this patch to build this package in nixpkgs.

lopsided98 avatar Oct 19 '22 23:10 lopsided98