roslint icon indicating copy to clipboard operation
roslint copied to clipboard

roslint doesn't seem to check function name style

Open spmaniato opened this issue 9 years ago • 1 comments

This is a follow-up from http://answers.ros.org/question/246677

According to the ROS C++ style guide, function names should be camelCased (lower-case first letter), not CamelCased (capital-case first letter). However, roslint doesn't seem to complain about CamelCased function names. Actually, it doesn't complain even if a function name is under_scored 🤔

Here's a proof of concept:

void my_silly_test() {
    return;
}

And here's the output of catkin build --no-deps <package> --make-args roslint_<package>:

when starting a new scope, { should be on a line by itself  [whitespace/braces]

It correctly complains about the scope delimiter, but not the function name.

spmaniato avatar Oct 29 '16 15:10 spmaniato

I'd be delighted for a PR to patch in roslint fails for this. :)

mikepurvis avatar Oct 29 '16 21:10 mikepurvis