ros_comm icon indicating copy to clipboard operation
ros_comm copied to clipboard

fix char signedness issue for test_base64 on ARM and RISC-V

Open alexfanqi opened this issue 4 years ago • 0 comments

tested on riscv64 and amd64 machines, I am sure ARM should also work.

char on some machines like ARM and RISC-V is by default unsigned. Using signed literals will cause Wnarrow errors from compiler.

I am not sure if this is the most proper fix. And I guess it would be best if the bundled libb64 can be updated because it is more portable and clear to use signed char as decoder and encoder argument.

I am sorry about commit reference noises in the origin issue.

alexfanqi avatar Nov 23 '21 05:11 alexfanqi