robot_state_publisher icon indicating copy to clipboard operation
robot_state_publisher copied to clipboard

Fix destructors should be public virtual

Open Rayman opened this issue 8 months ago • 0 comments

I encountered some compilation errors with clang. It complains that the destructor is not virtual. According to the cpp core guidelines a destructor should be either public and virtual or protected and non virtual. See also this link: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c35-a-base-class-destructor-should-be-either-public-and-virtual-or-protected-and-non-virtual

Rayman avatar Dec 07 '23 13:12 Rayman