diagnostics icon indicating copy to clipboard operation
diagnostics copied to clipboard
verified publisher icon ros

fix: replace deprecated MessageUniquePtr

Open homalozoa opened this issue 1 year ago • 1 comments

Hi! Here is a fix PR.

According to this PR https://github.com/ros2/rclcpp/commit/bdf1f8f78a95bb59c4549465300fd0a11867f137#diff-120be1036dd45a9b14efb6c9c5fd7d5f338869abc13a7d05067ea70183353e8bL109. MessageUniquePtr should be changed to std::unique_ptr<PublishedType, PublishedTypeDeleter> to keep the project going well.

homalozoa avatar Oct 24 '24 15:10 homalozoa

friendly ping @ct2034

homalozoa avatar Feb 06 '25 02:02 homalozoa

AFAICT the deprecation of MessageUniquePtr first will occur in kilted, so this PR really needs to be landed for the Kilted release. I've applied the patch in the ros2-kilted branch, and it seems to at least compile OK with a package that is using diagnostic_updater. Is there any way @ct2034 that this can be landed soon prior to Kilted?

rkent avatar May 15 '25 20:05 rkent

💚 All backports created successfully

Status Branch Result
✅ ros2-kilted

Questions ?

Please refer to the Backport tool documentation

ct2034 avatar May 16 '25 17:05 ct2034

done ✅ https://github.com/ros/rosdistro/pull/45809 and https://github.com/ros/rosdistro/pull/45810

ct2034 avatar May 16 '25 17:05 ct2034

Thanks!

rkent avatar May 16 '25 17:05 rkent

Good job!

homalozoa avatar May 18 '25 13:05 homalozoa