diagnostics icon indicating copy to clipboard operation
diagnostics copied to clipboard

DiscardAnalyzer doesn't work together with GenericAnalyzer

Open MCFurry opened this issue 5 years ago • 4 comments

Please see the following example of my diagnostic_aggregator configuration:

ecu:
  type: diagnostic_aggregator/GenericAnalyzer
  path: 'ECU'
  startswith: 'ecu_reporter'
  remove_prefix: 'ecu_reporter_node: '
ecu_discard1:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_676'
ecu_discard2:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_1235'

The problem seems that no diagnostic messages coming from this node are discarded anymore now that the GenericAnalyzer matches them as well and groups them. There doesn't seem to be any specific ordering in processing GenericAnalyzer vs DiscardAnalyzer? Am I miss-using the analyzers or is there a bug here?

In the end I would like to put all diagnostic messages from ecu_reporter_node in the same path such that rqt_robot_monitor groups them, unless they are discarded of course.

MCFurry avatar Oct 25 '19 12:10 MCFurry

This is probably fixed now. Can you update and re-test?

amilcarlucas avatar Sep 21 '20 13:09 amilcarlucas

Thx, I'll try to re-evaluate asap! Is this fix in the apt-released version or do I need to test the latest source?

MCFurry avatar Sep 21 '20 13:09 MCFurry

apt-released should have it

amilcarlucas avatar Sep 21 '20 14:09 amilcarlucas

apt-released should have it

Please see the following example of my diagnostic_aggregator configuration:

ecu:
  type: diagnostic_aggregator/GenericAnalyzer
  path: 'ECU'
  startswith: 'ecu_reporter'
  remove_prefix: 'ecu_reporter_node: '
ecu_discard1:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_676'
ecu_discard2:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_1235'

The problem seems that no diagnostic messages coming from this node are discarded anymore now that the GenericAnalyzer matches them as well and groups them. There doesn't seem to be any specific ordering in processing GenericAnalyzer vs DiscardAnalyzer? Am I miss-using the analyzers or is there a bug here?

In the end I would like to put all diagnostic messages from ecu_reporter_node in the same path such that rqt_robot_monitor groups them, unless they are discarded of course.

ok

yangyy11 avatar Jan 31 '21 02:01 yangyy11