moveit_calibration icon indicating copy to clipboard operation
moveit_calibration copied to clipboard

MoveIt Calibration Noetic Release (0.1.0)

Open JStech opened this issue 5 years ago • 10 comments

moveit.ros.org release documentation

Checklist

  • [ ] Update changelogs
  • [ ] Run ROS buildfarm prerelease test
  • [ ] Bloom
  • [ ] Write discourse post

Points for discussion

  1. Since it doesn't look like this has been released you can likely release it for both melodic and noetic off the same branch (master). Once you do this though on your next release you will likely only be able to release Noetic because there is an expectation that released packages for Melodic do not change.

JStech avatar Oct 05 '20 21:10 JStech

Since crigroup/handeye is not yet released for Noetic, it looks like this will have to wait.

JStech avatar Oct 07 '20 20:10 JStech

Are they on it? I think Francisco (the maintainer) is not with crigroup anymore.

felixvd avatar Oct 09 '20 11:10 felixvd

I've heard nothing so far. Personally I'd prefer to use a C++ implementation of the solver, since it'd make the code way cleaner, but @RoboticsYY reported that the Python implementation gave a better final result.

Typically I wouldn't be in a rush to get a noetic release out, but the annoyances with OpenCV 3.2 in melodic make it a bit more pressing, I feel.

JStech avatar Oct 09 '20 17:10 JStech

Now that the samples can be extracted, you could test a few implementations and see if that impression was well-founded.

felixvd avatar Nov 03 '20 05:11 felixvd

Well, @RoboticsYY shared the results of that investigation with me, and the CRI group solvers do generally outperform the alternatives that were available at the time. (Want to see for yourself? Watch our ROS World talk!).

OpenCV was not included in that investigation, so I'm still inclined to implement a solver plugin that uses it. In the meantime, though, the handeye package is being (or has been?) released to Noetic and ROS2, so we can move ahead with a Noetic release. Also, I think I now prefer to leave the existing sovler plugin as-is, and put the OpenCV solvers in a new plugin, giving users more options.

JStech avatar Nov 03 '20 16:11 JStech

I think we can revive this, as the CRI Group packages are in the pipeline for a Noetic release (whenever that happens). I just built everything in Noetic, with just those three CRI Group packages built from source, so I think it's good to go.

JStech avatar Nov 25 '20 20:11 JStech

The CRI Group packages have been released (after a bit of a hiccup). I'm gonna try to get this release moving again.

JStech avatar Jan 23 '21 03:01 JStech

@tylerjw IIRC this stalled because I can't push to the release repo or something, and then we figured we don't need yet another PickNikker doing MoveIt release stuff. Think you could take over getting this across the finish line?

JStech avatar Mar 24 '21 17:03 JStech

Yes, I'll create an internal issue to track this along with the other releases I need to do.

tylerjw avatar Mar 24 '21 18:03 tylerjw

@tylerjw ping

JStech avatar Apr 20 '21 03:04 JStech