moveit2_tutorials icon indicating copy to clipboard operation
moveit2_tutorials copied to clipboard

Published 20 hours ago • verified publisher icon ros-planning

Reordered code execution

Open AndyZe opened this issue 3 years ago • 4 comments

Description

I'm specifically talking about this issue: https://github.com/ros-planning/moveit2/issues/1474. I only changed the order in which code is executed by creating the MoveGroup Interface before the executor.

The format of the code was not changed. The text explaining what the code does was also changed to represent the newly added/removed lines.

Takes over from PR #514

AndyZe avatar Sep 19 '22 21:09 AndyZe

Are there other files that need to be modified before we merge the branch? I haven't been through the entire docs to confirm any other cases, but so far this is it.

AbduEhab avatar Sep 23 '22 11:09 AbduEhab

We are only waiting on CI to pass. It's nothing related to this PR. Sorry for the delay

AndyZe avatar Sep 23 '22 14:09 AndyZe

I think the correct fix for this is to enable Cyclone DDS, which is addressed in #519. So I vote to close this PR.

AndyZe avatar Sep 26 '22 21:09 AndyZe

@AndyZe should we go ahead and close this, since the fix is enabling cyclone DDS which is mentioned in the tutorials?

adlarkin avatar Mar 21 '23 15:03 adlarkin